Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130194 / 24.10 / Add additional ARC stats for UI #14069

Closed
wants to merge 1 commit into from
Closed

NAS-130194 / 24.10 / Add additional ARC stats for UI #14069

wants to merge 1 commit into from

Conversation

Qubad786
Copy link
Contributor

Problem

The UI requires new files that are currently missing in the realtime.reporting event.

Solution

The necessary fields have been added to the realtime.reporting event. The UI can now retrieve the relevant information from the following keys in ZFS ARC reporting:

  • Current size: arc_size
  • Maximum size: arc_max_size
  • Demand data hits: arc_demand_data_hits
  • Demand metadata hits: arc_demand_metadata_hits
  • Prefetch data hits: arc_prefetch_data_hits
  • Prefetch metadata hits: arc_prefetch_metadata_hits

Reference

https://learn.netdata.cloud/docs/collecting-metrics/freebsd/zfs
https://github.com/netdata/netdata/blob/master/src/collectors/proc.plugin/zfs_common.c#L19C24-L19C28

@Qubad786 Qubad786 added the jira label Jul 23, 2024
@Qubad786 Qubad786 requested a review from a team July 23, 2024 19:44
@bugclerk bugclerk changed the title Add additional ARC stats for UI NAS-130194 / 24.10 / Add additional ARC stats for UI Jul 23, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130194

1 similar comment
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130194

yocalebo
yocalebo requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate but I've been working on this ticket all day. Netdata doesn't calculate the values properly. We need to go back to doing this ourselves unfortunately.

@Qubad786 Qubad786 closed this Jul 23, 2024
@Qubad786 Qubad786 deleted the mrehan/add-arc-related-keys branch July 23, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yocalebo yocalebo yocalebo requested changes

Assignees
No one assigned
Labels
jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qubad786 @bugclerk @yocalebo